Re: [ 05/38] PCI: ignore pre-1.1 ASPM quirking when ASPM is disabled

[Greg KH]

On Mon, Mar 19, 2012 at 11:04:16AM -0500, Jonathan Nieder wrote:
> Greg KH wrote:
> > On Mon, Mar 19, 2012 at 11:20:34AM +0100, Jiri Slaby wrote:
> 
> >> The commit below is reported to crash the machine in the early init. See
> >> the first reply to this message (lkml.org seems to be down right now):
> >> lkml.org/lkml/2012/3/18/132
> >
> > Yes, but this patch fixes machines that others have been reporting
> > problems with, so, what am I supposed to do?
> >
> > I'll stick with this patch for now, and hope that Matthew fixes this up
> > in Linus's tree and I'll suck that fix in when it gets there.  Is that
> > ok?
> 
> Just one data point from a distro perspective: regressions are way
> more painful than problems that already existed.  So it seems worth
> considering dropping the patch for now and grabbing the patch and fix
> when ready.

I think you are missing the fact that this patch itself is fixing a
regression from a previous patch :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/