Re: [rfc][patches] fix for munmap/truncate races

From: Linus Torvalds
Date: Sun Mar 18 2012 - 18:01:34 EST


On Sun, Mar 18, 2012 at 12:07 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> -       tlb_finish_mmu(&tlb, 0, end);
> +       tlb_finish_mmu(&tlb, 0, -1);

Hmm. The fact that you drop the end pointer means that some
architectures that optimize the TLB flushing for ranges now
effectively can't do it any more.

Now, I think it's only ia64 that really is affected, but it *might* matter.

In particular, ia64 has some logic for "if you only flush one single
region, you can optimize it", and the region sizes are in the
terabytes. And I'm pretty sure you broke that - I'm just not entirely
sure how much we care.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/