Re: [RFC] firmware loader: retry _nowait requests when userhelper isnot yet available

From: Linus Torvalds
Date: Sat Mar 17 2012 - 22:22:27 EST


On Sat, Mar 17, 2012 at 5:29 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
>
> The patch below (untested) goes slightly into that direction, although not as
> far as to modify fw_create_instance().  It does, however, split
> _request_firmware() into "prepare", "load" and "cleanup" parts and moves
> the usermodehelper check along with the read-locking of umhelper_sem down
> to the callers, ie. request_firmware() and request_firmware_work_func().

Looks fairly reasonable to me from a quick read-through, and the code
seems to make sense.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/