Re: [ 10/41] CIFS: Do not kmalloc under the flocks spinlock

[Ben Hutchings]

On Sat, 2012-03-17 at 10:14 +0400, Pavel Shilovsky wrote:
> 17 ÐÐÑÑÐ 2012 Ð. 6:37 ÐÐÐÑÐÐÐÐÑÐÐÑ Ben Hutchings <ben@xxxxxxxxxxxxxxx> ÐÐÐÐÑÐÐ:
> > On Fri, Mar 16, 2012 at 04:38:20PM -0700, Greg KH wrote:
> >> 3.2-stable review patch.  If anyone has any objections, please let me know.
[...]
> > But we test this before flock->fl_flags & FL_POSIX, which means we
> > don't know whether this lock actually needs to be assigned one of
> > those structures.  So it appears that we might report a spurious error
> > if the lock list ends with a mandatory lock.  If so, this is
> > relatively harmless but does need to be fixed.
> >
> 
> You are right here, thanks for the catch! I will repost the patch asap.

This has already been merged into Linus's tree, so you need to submit a
patch to apply on top of it.

Ben.

-- 
Ben Hutchings
Life would be so much easier if we could look at the source code.

Attachment: signature.asc
Description: This is a digitally signed message part