Re: [PATCHv2 3/3] simple_open: Automatically convert tosimple_open()

From: Andrew Morton
Date: Fri Mar 16 2012 - 19:49:14 EST


On Tue, 13 Mar 2012 02:46:28 -0700
Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:

> Many users of debugfs copy the implementation of default_open()
> when they want to support a custom read/write function op. This
> leads to a proliferation of the default_open() implementation
> across the entire tree. Now that the common implementation has
> been consolidated into libfs we can replace all the users of this
> function with simple_open().
>
>
> ...
>
> --- a/drivers/net/wireless/wl12xx/debugfs.c
> +++ b/drivers/net/wireless/wl12xx/debugfs.c
>

This broke.

I'm hitting quite a lot of build errors from this patch. I'm not
confident that I will be able to compile-test every file that it
touches so I shall drop the patch.

Please fix it all up, compile-test *every* file, then resend.

If possible, against linux-next, please. Quite a few things in this
area have been changed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/