Re: [PATCH v3 2/2] input: add driver support for MAX8997-haptic

[Samuel Ortiz]

Hi Dmitry,

On Wed, Mar 14, 2012 at 08:48:28AM -0700, Dmitry Torokhov wrote:
> On Wed, Mar 14, 2012 at 11:47:42PM +0900, Chanwoo Choi wrote:
> > Hi Dmitry,
> > 
> > > This is not proper locking between playing effect and suspend. Now that
> > > you are using workqueue you need to synchronize access with it, not with
> > > play_effect method.
> > > 
> > > Does the following patch work for you?
> > > 
> > 
> > Your patch is worked on TRATS board based on EXYNOS4210 but, you should
> > apply following patch because 'chip->enabled' is used on
> > max8997_haptic_configure() function to enable/disable haptic motor.
> 
> OK, excellent. I'll pick up this fix and apply the driver for 3.4 queue,
> thanks!
Your patch depends on the MFD changes Choi sent along the input driver. I
think it would make more sense for me to take it. What do you think ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/