Re: [PATCH] [SCSI] pm8001: fix endian issue with code optimization.

[Mark Salyzyn]

One more NAK:

> @@ -3497,7 +3499,7 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void* piomb)
> static void process_one_iomb(struct pm8001_hba_info *pm8001_ha, void *piomb)
> {
> 	u32 pHeader = (u32)*(u32 *)piomb;
> -	u8 opc = (u8)((le32_to_cpu(pHeader)) & 0xFFF);
> +	u8 opc = (u8)(pHeader & 0xFFF);
> 
> 	PM8001_MSG_DBG(pm8001_ha, pm8001_printk("process_one_iomb:"));

The swap is necessary. Should be:

	__le32 pHeader = (__le32)*(__le32 *)piomb;

instead ...

Sincerely -- Mark Salyzyn

On Mar 7, 2012, at 9:58 AM, Mark Salyzyn wrote:

> NAK on one point.
> 
> The fw_flash_Update_resp structure erroneously defines tag as a dma_addr_t, when in fact it should be an __le32, as the response hTag is reported in this field. The removal of the le32_to_cpu(ppayload->tag) was done to remove a warning, but is incorrect. The warning should have been solved by correctly defining the tag element in the structure.
> 
> Sincerely -- Mark Salyzyn
> 
> On Feb 26, 2012, at 11:51 PM, Jack Wang wrote:
> 
>> Thanks for fix.
>> Acked-by: Jack Wang <jack_wang@xxxxxxxxx>
>>> 
>>> From: Santosh Nayak <santoshprasadnayak@xxxxxxxxx>
>>> 
>>> 1. Fix endian issue.
>>> 2. Fix the following warning :
>>>   " drivers/scsi/pm8001/pm8001_hwi.c:2932:32: warning: comparison
>>>     between 'enum sas_device_type' and 'enum sas_dev_type'".
>>> 3. Few code optimization.
>>> 
>>> Signed-off-by: Santosh Nayak <santoshprasadnayak@xxxxxxxxx>
>>> ---
>>> . . .
>>> @@ -3149,7 +3152,7 @@ mpi_fw_flash_update_resp(struct pm8001_hba_info
>>> *pm8001_ha, void *piomb)
>>> 	struct fw_control_ex	fw_control_context;
>>> 	struct fw_flash_Update_resp *ppayload
>>> 		(struct fw_flash_Update_resp *)(piomb + 4);
>>> -	u32 tag = le32_to_cpu(ppayload->tag);
>>> +	u32 tag = ppayload->tag;
>>> 	struct pm8001_ccb_info *ccb = &pm8001_ha->ccb_info[tag];
>>> 	status = le32_to_cpu(ppayload->status);
>>> 	memcpy(&fw_control_context,
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/