Re: [PATCH] uevent: send events in correct order according to seqnum (v2)

[Kay Sievers]

On Wed, Mar 7, 2012 at 10:59, Andrew Vagin <avagin@xxxxxxxxxx> wrote:
> The queue handling in the udev daemon assumes that the events are
> ordered.

> - Â Â Â retval = add_uevent_var(env, "SEQNUM=%llu", (unsigned long long)seq);
> + Â Â Â retval = add_uevent_var(env, "SEQNUM=%llu", (unsigned long long)++uevent_seqnum);
> Â Â Â Âif (retval)
> Â Â Â Â Â Â Â Âgoto exit;

We need to unlock the mutex before the goto exit?

Other than that, looks good to me.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/