Re: [PATCH 2/5] OpenRISC: Use generic bitops.h

From: Richard Weinberger
Date: Fri Mar 02 2012 - 03:47:12 EST


Am 02.03.2012 07:50, schrieb Jonas Bonn:
> On Fri, 2012-03-02 at 01:55 +0100, Richard Weinberger wrote:
>> There is no need to reinvent the wheel.
>
> NAK... we have optimized versions for some of these operations so the
> generic header isn't right for us.

Sorry, I missed that.

> Have a look at arch/openrisc/asm/include/bitops.h to see which functions
> we override with accelerated versions.

Okay, but some operations are missing in your bitopts.h.
Like test_bit_le() or find_next_zero_bit_le().

#include <asm-generic/bitops/le.h>
Should to the job...

Thanks,
//richard

Attachment: signature.asc
Description: OpenPGP digital signature