Re: [PATCH 2/6] vt: push down the tty lock so we can see what isleft to tackle

[Jiri Slaby]

On 03/01/2012 08:50 PM, Alan Cox wrote:
> --- a/drivers/tty/vt/vt_ioctl.c
> +++ b/drivers/tty/vt/vt_ioctl.c
> @@ -281,7 +281,6 @@ int vt_ioctl(struct tty_struct *tty,
>  
>  	console = vc->vc_num;
>  
> -	tty_lock();

Note that this breaks bisection. Further in vt_ioctl, there is a call to
vt_event_wait_ioctl which calls vt_event_wait and that calls
wait_event_interruptible_tty which unlocks BTM.

You change wait_event_interruptible_tty to wait_event_interruptible even
in 4/6.

The VT_WAITEVENT case should have tty_lock until 4/6 (and not longer).

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/