Re: [PATCH V2 RESEND] fsl-sata: I/O load balancing

From: Li Yang
Date: Wed Feb 15 2012 - 02:22:23 EST


On Wed, Feb 15, 2012 at 1:49 PM, Qiang Liu <qiang.liu@xxxxxxxxxxxxx> wrote:

Hi Liu Qiang,

The patch is fine except for the title and comment. It's too vague to
say I/O load balancing. You need explicit description like "add
interrupt coalescing support" as title.

> Reduce interrupt signals through reset Interrupt Coalescing Control Reg.
> Provide dynamic method to adjust interrupt signals and timer ticks by sysfs.
> It is a tradeoff for different applications.

How about:

Adds support for interrupt coalescing feature to reduce interrupt
events. Provides mechanism of adjusting coalescing count and timeout
tick by sysfs on runtime, so that tradeoff of latency and CPU load can
be made depending on applications.

- Leo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/