Re: [PATCH v1] percpu: use raw_local_irq_* in _this_cpu op

[Eric Dumazet]

Le mercredi 15 fÃvrier 2012 Ã 13:08 +0800, Ming Lei a Ãcrit :

> Just several warnings, no errors. Also the 5 warnings are introduced
> by previous commit, sounds nothing to do with motivation of this patch.
> You may prepare a standalone patch to fix all the code style in this file, :-)
> 

Oh well, I dont use checkpatch but spoke about trailing \

Cant you see them on your screen ?

We had :

#define _this_cpu_generic_to_op(pcp, val, op)				\
do {									\
	unsigned long flags;						\
	local_irq_save(flags);						\
	*__this_cpu_ptr(&(pcp)) op val;					\
	local_irq_restore(flags);					\
} while (0)


You want :

#define _this_cpu_generic_to_op(pcp, val, op)				\
do {									\
	unsigned long flags;						\
	raw_local_irq_save(flags);						\
	*__this_cpu_ptr(&(pcp)) op val;					\
	raw_local_irq_restore(flags);					\
} while (0)


I suggest :

#define _this_cpu_generic_to_op(pcp, val, op)				\
do {									\
	unsigned long flags;						\
	raw_local_irq_save(flags);					\
	*__this_cpu_ptr(&(pcp)) op val;					\
	raw_local_irq_restore(flags);					\
} while (0)


Is it clear now ?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/