Re: [PATCH 3/6] usermodehelper: kill umh_wait, renumber UMH_* constants

[Rusty Russell]

On Tue, 14 Feb 2012 17:48:21 +0100, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> No functional changes. It is not sane to use UMH_KILLABLE with
> enum umh_wait, but obviously we do not want another argument in
> call_usermodehelper_* helpers. Kill this enum, use the plain int.

Seems like a step backwards.  Perhaps reorder the enum, but implying an
explicit range of values explicit by using an enum seems good.

But it's a minor gripe, feel free to ignore.

Entire series:
Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Thanks for this!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/