Re: [PATCH V3] kmsg_dump: Don't run on non-error paths by default

[Matthew Garrett]

On Tue, Feb 14, 2012 at 01:05:22PM -0800, Andrew Morton wrote:

> So if I'm understanding it correctly, this patch reverts the kernel
> behaviour to what it was before 04c6862c055fb687c9 ("kmsg_dump: add
> kmsg_dump() calls to the reboot, halt, poweroff and emergency_restart
> paths").  The user must now set printk.always_kmsg_dump to get the
> 04c6862c055fb687c9 behaviour.

Correct.

> Correct?  If so, we should get this into 3.3 so we don't have a oddball
> behaviour in one particular kernel release.

That would be my preference.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/