Re: [PATCHv4 0/9] perf tool: parser generator for events parsing

From: Peter Zijlstra
Date: Tue Feb 14 2012 - 16:03:22 EST


On Tue, 2012-02-14 at 21:57 +0100, Peter Zijlstra wrote:
> On Tue, 2012-02-14 at 21:20 +0100, Peter Zijlstra wrote:
> > OK, this one works. the attributes thing wants NULL termination.
> > Thanks
> > for mentioning that Jiri.
>
> OK, it mostly works, except:
>
> perf record -e "cpu/config=0x108000c0/upp" ./loop_1b_locks
>
> doesn't seem to work...

This seems to come back to hardcoding config* vs including it in every
single format description.

I prefer to have all perf_event_attr fields (of interest) hard-coded in
the parser so that we can omit them for all actual format descriptions.

These would be: period, config, config1, config2 and stephane's new
branch_sample_type, although that might want to get a shorter name.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/