Re: [PATCH] modpost: Fix section warnings for ARM for many compilers

From: Rusty Russell
Date: Mon Feb 13 2012 - 19:39:13 EST


On Mon, 13 Feb 2012 22:51:18 +0000, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote:
> On Mon, Feb 13, 2012 at 11:26:52PM +0100, Uwe Kleine-KÃnig wrote:
> > On Mon, Feb 13, 2012 at 01:24:01PM -0800, Tony Lindgren wrote:
> > Maybe:
> >
> > #ifndef R_ARM_CALL
> > #warning "you're elf.h include is outdated"
>
> "You are elf.h include is outdated" does not make sense.
>
> Why are you calling Tony an elf.h include?

Because he knew it would attract the attention of pedants to the patch?
:)

Just do the #ifndef, and skip the warning. There's not much the poor
user receiving the warning can do about it.

Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/