Re: [PATCH V1 0/3] Support for open drain gpios in gpilib/fixedregulators.

From: Mark Brown
Date: Mon Feb 13 2012 - 17:10:21 EST


On Mon, Feb 13, 2012 at 09:02:03PM +0100, Linus Walleij wrote:
> On Mon, Feb 13, 2012 at 7:29 AM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:

> > This is series of patches  to add support of the open drain gpios
> > in standard gpio library and using this in fixed regulators.
> > - Added GPIOF_OD flag so that client can request the gpio with this flag.
> > - Added support for the sysfs interface for open-drain.
> > - Handle open drain gpio configuration properly.
> > - Use this flag in fixed regualtor to tell that gpio is open drain.
> > - Gpio documentation changes to have support for open-drain.

> My gut feeling is that this stuff needs to go into pinctrl.

Does that really make sense for cases like this where we're emulating
the open drain support rather than actually configuring the hardware
into an open drain mode? That emulation is a pretty GPIO specific
thing.

Attachment: signature.asc
Description: Digital signature