Re: [PATCH 1/2] bluetooth: Use more current logging styles

From: Marcel Holtmann
Date: Mon Feb 13 2012 - 02:24:00 EST


Hi Joe,

> > Why is this a good thing?
>
> It's more similar to the rest of the <foo>_<level> uses.
> Other than that, it's a little smaller.
>
> > And in your patch we have bt_err not having \n\n in the end.
>
> There shouldn't be a newline at all with the
> actual functions bt_err or bt_info except
> at the uses.

then you might wanna read your patch again ;)

> This is the style used in pr_<level> so that
> it becomes possible to use pr_cont.

Since we don't have a bt_cont, I don't see why bother changing this
right now.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/