Re: [PATCH 2/2] bluetooth: Convert BT_DBG to pr_debug

[Joe Perches]

On Mon, 2012-02-13 at 07:37 +0100, Marcel Holtmann wrote:
> > No need to obfuscate, just use the normal debugging macro.
> > Add "\n" to uses, align arguments, coalesce formats.
> > Fix a typo and fix a bad format extended by a line continuation.
> what is this patch buying us.

Easier greps of pr_debug.
BT_DBG is just an unnecessary useless wrapper.

> The only useful change would be to move to dev_printk, but we are not
> there yet.

Maybe dev_dbg, but there isn't always an
appropriate device * available.

There are many uses of:
	pr_debug("%s ...", (some struct hci_dev *)->name, ...)

that could be something like

hci_dev_dbg((some struct hci_dev *), fmt, ...)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/