Re: [PATCH resend] asm/types.h: All architectures use int-ll64.h inkernelspace

From: Al Viro
Date: Sat Feb 11 2012 - 04:45:38 EST


On Sat, Aug 13, 2011 at 11:25:59PM +0200, Arnd Bergmann wrote:
> On Saturday 13 August 2011 21:53:43 Geert Uytterhoeven wrote:
> > Now all 64-bit architectures have been converted to int-ll64.h, we can
> > deprecate int-l64.h in kernelspace:
> > - Add a check to prevent new architectures from using int-l64.h in
> > kernelspace,
> > - Update documentation, as the casts to (unsigned) long long are no longer
> > needed.
> >
> > For backwards compatibility, alpha, ia64, mips, and powerpc still use
> > int-l64.h in userspace.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > For the documentation parts:
> > Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>
> I believe that Al Viro is working on a patch to unify all umode_t definitions
> so that it becomes unsigned short everywhere. Once that is done,
> asm-generic/int-ll64.h can become asm-generic/types.h and all architectures
> can use that.

Umm... That has happened and yes, asm-generic/types.h is currently
equivalent to asm-generic/int-ll64.h. What exactly are you planning
to do? Just rename the latter to the former and do search-and-replace
over the tree? We still have places that pull int-l64.h, albeit only
!__KERNEL__ ones (i.e. everything under #ifdef __KERNEL__ in there
seems to be killable)...

AFAICS, for quite a few of those guys we can simply add bitsperlong.h
and add types.h to generic-y; is that the plan?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/