Re: [PATCH v3 1/2] mxs-dma : move the mxs dma.h to a more commonplace

[Shawn Guo]

On Sat, Feb 11, 2012 at 07:36:50AM +0800, Huang Shijie wrote:
> hi,
> 
> On Sat, Feb 11, 2012 at 12:21 AM, Shawn Guo <shawn.guo@xxxxxxxxxx> wrote:
> > On Tue, Feb 07, 2012 at 06:54:34PM +0800, Huang Shijie wrote:
> >> Move the header to a more common place.
> >> The mxs dma engine is not only used in mx23/mx28, but also used
> >> in mx50/mx6q. ÂIt will also be used in the future chips.
> >>
> >> Rename it to mxs-dma.h
> >>
> >> change mxs-dma driver, mxs-mmc driver, gpmi-nand driver, mxs-saif driver
> >> to the new header file.
> >>
> >> Signed-off-by: Huang Shijie <b32955@xxxxxxxxxxxxx>
> >> ---
> >> Âdrivers/dma/mxs-dma.c               Â|  Â2 +-
> >> Âdrivers/mmc/host/mxs-mmc.c             |  Â2 +-
> >> Âdrivers/mtd/nand/gpmi-nand/gpmi-nand.h       |  Â2 +-
> >> Â.../include/mach/dma.h => include/linux/mxs-dma.h Â| Â Â0
> >> Âsound/soc/mxs/mxs-pcm.c              Â|  Â2 +-
> >> Âsound/soc/mxs/mxs-pcm.h              Â|  Â2 +-
> >> Âsound/soc/mxs/mxs-saif.c              |  Â2 +-
> >> Â7 files changed, 6 insertions(+), 6 deletions(-)
> >> Ârename arch/arm/mach-mxs/include/mach/dma.h => include/linux/mxs-dma.h (100%)
> >
> > I suggested you rename it include/linux/fsl/mxs-dma.h [1]. ÂIt seems
> > you are ignoring the comment. ÂCan you explain why it's not a
> > reasonable suggestion?
> 
> For gpmi-nand.h is placed in include/linux/mtd/ directory, so i think
> it's better to place the mxs-dma.h
> to similar include/linux/dma/ directory, but the directory does not exit.
> 
Yes, from subsystem point of view, it makes sense too.

> If i place it at include/linux/fsl/mxs-dma.h , i have to create a new
> folder, I am not sure i have the right
> to do so. But i can try it in the next version.
> 
So either way works for me.  But you need to create a folder anyway.
So let's do it to test people.

> thanks a lot.
> 
> 
> 
> >
> > And Wolfram and Mark told you that you need to Cc subsystem maintainers
> > to collect their acks [2]. ÂBut you are still not Ccing Mark Brown and
> > Chris Ball for sound/soc/ and drivers/mmc changes. ÂSo you are not
> > listening.
> 
> ok, i will CC them in next version.  Iãreally did not know to whom Iãshould cc .
> 
The file MAINTAINERS is created for this purpose.

-- 
Regards,
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/