Re: [PATCH 2/2] x86, reschedule: check to see if system is shuttingdown

[Don Zickus]

On Fri, Feb 10, 2012 at 10:42:24PM +0000, Luck, Tony wrote:
> -		WARN_ON(1);
> +		if (atomic_read(&stopping_cpu) == -1)
> +			/* system is not shutting down.. yell */
> +			WARN_ON(1);
> 
> Should that be written as:
> 
> 		/* system is not shutting down.. yell */
> 		WARN_ON(atomic_read(&stopping_cpu) == -1);
> 
> the
> 		if (something)
> 			WARN_ON(1);
> 
> looks weird.

Indeed.  In my haste, I wrote some pretty sloppy code.

Thanks for catching that.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/