Re: [PATCH 4/9] PCI: Fix cardbus bridge resources as optional sizehandling

[Jesse Barnes]

On Tue, 7 Feb 2012 22:11:22 -0800
Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> On Tue, Feb 7, 2012 at 9:01 PM, Ram Pai <linuxram@xxxxxxxxxx> wrote:
> >
> > ..snip..
> >> Â Â Â Â* If we have prefetchable memory support, allocate
> >> Â Â Â Â* two regions. ÂOtherwise, allocate one region of
> >> Â Â Â Â* twice the size.
> >> Â Â Â Â*/
> >> Â Â Â if (ctrl & PCI_CB_BRIDGE_CTL_PREFETCH_MEM0) {
> >> Â Â Â Â Â Â Â b_res[2].start = pci_cardbus_mem_size;
> >> Â Â Â Â Â Â Â b_res[2].end = b_res[2].start + pci_cardbus_mem_size - 1;
> >> Â Â Â Â Â Â Â b_res[2].flags |= IORESOURCE_MEM | IORESOURCE_PREFETCH |
> >> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â IORESOURCE_STARTALIGN;
> >> Â Â Â Â Â Â Â if (realloc_head) {
> >> Â Â Â Â Â Â Â Â Â Â Â b_res[2].end -= pci_cardbus_mem_size;
> >> Â Â Â Â Â Â Â Â Â Â Â add_to_list(realloc_head, bridge, b_res+2,
> >> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âpci_cardbus_mem_size, pci_cardbus_mem_size);
> >> Â Â Â Â Â Â Â }
> >>
> >> Â Â Â Â Â Â Â /* reduce that to half */
> >> Â Â Â Â Â Â Â b_res_3_size = pci_cardbus_mem_size;
> >> Â Â Â }
> >
> > ACK. Ok. got it. This looks correct.
> 
> Good, So we have
> 
> Acked-by: Ram Pai <linuxram@xxxxxxxxxx>
> Tested-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>
> 
> Hope Jesse will not miss to add them

Yeah looks fine.  I'd like to see an ack from Dominik on 5/9 as well
though.  Can you include the acks and tested-bys when you re-post 3-9
with bug references and any other comments included?

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

Attachment: signature.asc
Description: PGP signature