Re: [PATCH 1/9] pci: Fix pci cardbus removal

From: Jesse Barnes
Date: Fri Feb 10 2012 - 15:20:25 EST


On Sat, 4 Feb 2012 22:55:00 -0800
Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> During test busn_res allocation with cardbus, found pci card removal is not
> working anymore, and it turns out it is broken by:
>
> |commit 79cc9601c3e42b4f0650fe7e69132ebce7ab48f9
> |Date: Tue Nov 22 21:06:53 2011 -0800
> |
> | PCI: Only call pci_stop_bus_device() one time for child devices at remove
>
> that patch changed pci_remove_behind_bridge behavoir that yenta_carbus depends.
>
> Restore the old behavoir of pci_remove_behind_bridge by:
> 1. rename pci_remove_behind_bridge to __pci_remove_behind_bridge, and let
> __pci_remove_bus_device() call it instead.
> 2. add pci-stop_befind_bridge that will stop device under bridge
> 3. add back pci_remove_behind_bridge that will stop and remove device
> under bridge.
>
> This one is for v3.3

Applied to -fixes with Dominik's tested-by. A nice cleanup on top
might be to rename pci_remove_behind_bridge to
pci_stop_remove_behind_bridge or something to indicate that it's
calling stop each time as well...

--
Jesse Barnes, Intel Open Source Technology Center

Attachment: signature.asc
Description: PGP signature