[PATCH 2/2] DAC960: fix -Wuninitialized warning

From: Danny Kukawka
Date: Fri Feb 10 2012 - 09:54:40 EST


Set CommandMailbox with memset before use it. Fix for:

drivers/block/DAC960.c: In function âDAC960_V1_EnableMemoryMailboxInterfaceâ:
arch/x86/include/asm/io.h:61:1: warning: âCommandMailbox.Bytes[12]â
may be used uninitialized in this function [-Wuninitialized]
drivers/block/DAC960.c:1175:30: note: âCommandMailbox.Bytes[12]â
was declared here

Signed-off-by: Danny Kukawka <danny.kukawka@xxxxxxxxx>
---
drivers/block/DAC960.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
index 66b8729..40000e2 100644
--- a/drivers/block/DAC960.c
+++ b/drivers/block/DAC960.c
@@ -1177,7 +1177,8 @@ static bool DAC960_V1_EnableMemoryMailboxInterface(DAC960_Controller_T
int TimeoutCounter;
int i;

-
+ memset(&CommandMailbox, 0, sizeof(DAC960_V1_CommandMailbox_T));
+
if (pci_set_dma_mask(Controller->PCIDevice, DMA_BIT_MASK(32)))
return DAC960_Failure(Controller, "DMA mask out of range");
Controller->BounceBufferLimit = DMA_BIT_MASK(32);
--
1.7.7.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/