Re: [PATCH v3 01/31] events/hw_event: Create a Hardware EventsReport Mecanism (HERM)

[Borislav Petkov]

On Thu, Feb 09, 2012 at 10:01:00PM -0200, Mauro Carvalho Chehab wrote:
> In order to provide a proper hardware event subsystem, let's
> encapsulate hardware events into a common trace facility, and
> make both edac and mce drivers to use it. After that, common
> facilities can be moved into a new core for hardware events
> reporting subsystem. This patch is the first of a series, and just
> touches at mce.

I think it would work too if you had only one event:

* trace_hw_error(...)

which would have as an argument a string describing it, like
"Uncorrected Memory Read Error", "Memory Read Error (out of range)" "TLB
Multimatch Error" etc., followed by the rest of the error info.

Currently, you're introducing at least 5 trace_* calls _only_ for memory
errors. What about the remaining couples of tens of errors which haven't
been addressed yet?

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/