Re: 8250 move broke the build on sparc

From: Paul Gortmaker
Date: Thu Feb 09 2012 - 18:48:21 EST


[Re: 8250 move broke the build on sparc] On 09/02/2012 (Thu 17:48) David Miller wrote:

> From: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> Date: Thu, 9 Feb 2012 17:36:53 -0500
>
> > It only uses suncore.h for sunserial_register_minors (and unreg).
> > Would you like it better if I killed all ifdefs and the include
> > and used an incantation of weak instead? Might be cleaner....
>
> It's the "../" that's ugly, not the include and usage itself.
>
> If it's now going to be included from multiple dirs, we should
> probably move it to include/linux/sunserialcore.h or similar.

Thanks for the suggestion, I wasn't thinking in that direction.

I'm pretty sure the ifdef SPARC around the include in 8250.c
could be tossed, but with my luck lately, I figured it would be
best to just leave it exactly as it was.

Paul.
--