Re: [PATCH V1] regmap: add bulk_write() for non-volatile register set

[Mark Brown]

On Thu, Feb 09, 2012 at 05:42:11PM +0530, Laxman Dewangan wrote:

> +	if (vol || map->cache_type == REGCACHE_NONE) {
> +		ret = _regmap_raw_write(map, reg, val, val_bytes * val_count);

You still need to do the byte swap here.

> +	} else {
> +		for (i = 0; i < val_count; i++) {
> +			memcpy(map->work_buf, val + (i * val_bytes), val_bytes);
> +			ival = map->format.parse_val(map->work_buf);

They're currently symmetric but really this should use format_val().

Attachment: signature.asc
Description: Digital signature