Re: [PATCH v10 3.3-rc2 1/9] uprobes: Install and removebreakpoints.

[Srikar Dronamraju]

> >>
> > 
> > I am confused by why we need to call insn_get_length(insn) before
> > checking insn->rex_prefix.nbytes? Is it needed.
> 
> Ah, certainly, no, if the insn is already decoded.

Okay, 

> > 
> > 	uprobe->arch_info.rip_rela_target_address = 0x0;
> > 	if (!insn_rip_relative(insn))
> > 		return;
> 
> Here, I think it is better to add a comment that
> insn_rip_relative() decodes until modrm. :)

Will do.

> 
> > 	return;
> > }
> 
> Confirmed, this looks good to me ;)
> 
> Thanks!

Okay, Thanks for confirming, 

Do you have a handy instruction whose REX.B is set that I could use to test.

-- 
Thanks and Regards
Srikar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/