Re: [PATCH 3/3] pch_udc: Specifies GPI port number at configuration.

From: Felipe Balbi
Date: Thu Feb 09 2012 - 02:56:32 EST


On Fri, Feb 03, 2012 at 02:50:02PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 03-02-2012 11:14, Tomoya MORINAGA wrote:
>
> >Problem:
> > The GPIO ports used for detecting VBUS may be different
> > on each platform.
> > This should be easily modifiable.
> >Solution:
> > In configuration, GPI port number is specified.
>
> Isn't it better to pass this with driver's platform data.

Yes, please re-factor this port. This doesn't fit as a compile-time
choice.

--
balbi

Attachment: signature.asc
Description: Digital signature