Re: [PATCH v3 3/3] KVM: perf: kvm events analysis tool

[David Ahern]

On 02/08/2012 08:07 PM, Xiao Guangrong wrote:
> Thanks for your review and explanation!
> 
> The code of commit_pager_choice():
> static void commit_pager_choice(void)
> {
> 	switch (use_pager) {
> 	case 0:
> 		setenv("PERF_PAGER", "cat", 1);
> 		break;
> 	case 1:
> 		/* setup_pager(); */
> 		break;
> 	default:
> 		break;
> 	}
> }
> 
> setup_pager() is not called.
> 
> And it looks like kvm-events can not show the result properly if
> i try to remove setup_pager.
> 
> 

You're right; I blew right past the fact that it is a comment.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/