Re: [PATCH] cdrom: move shared static to cdrom_device_info

From: Jens Axboe
Date: Wed Feb 08 2012 - 14:06:06 EST


On 02/08/2012 06:32 PM, Paolo Bonzini wrote:
> The keeplocked variable in the cdrom driver is shared across multiple
> drives, but set in per-device ioctls. Move it to the per-device struct,
> avoiding that the setting on one drive affects the driver's behavior
> when closing another.
>
> [ Impact: limit udev's confusion to one drive when a CD burning program
> unlocks the CD door at the end of burning. ]
>
> Cc: Jens Axboe <axboe@xxxxxxxxx>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> ---
> Would this be acceptable for 3.3?

Yeah, looks simple enough. I thought we had a module parameter for this
too, but we do not. So I've applied it for 3.3.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/