Re: [PATCH 4/4] Netfilter: xt_LOG: Implement ring buffer support

[Pablo Neira Ayuso]

On Sun, Feb 05, 2012 at 01:14:52AM +0100, Richard Weinberger wrote:
> This patch introduces NETFILTER_XT_TARGET_LOG_RING.
> It allows logging into various ring buffers which are
> represented as pipe-like files in /proc/net/netfilter/xt_LOG_ring/.
> 
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
>  include/linux/netfilter/xt_LOG.h    |   13 +-
>  include/net/netfilter/nf_log.h      |    1 +
>  include/net/netfilter/xt_log_ring.h |   24 +
>  net/netfilter/Kconfig               |   13 +
>  net/netfilter/Makefile              |    2 +
>  net/netfilter/xt_LOG.c              |  921 -----------------------------
>  net/netfilter/xt_LOG_core.c         | 1108 +++++++++++++++++++++++++++++++++++
>  net/netfilter/xt_LOG_ring.c         |  430 ++++++++++++++

Can you avoid this rename and splitting LOG into two files? I prefer
having everything into the same file xt_LOG.c.

Apart from that, this looks fine to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/