Re: [PATCH v4 2/4] irq: add irq_domain support to generic-chip

From: Shawn Guo
Date: Wed Feb 08 2012 - 01:16:56 EST


On Fri, Feb 03, 2012 at 04:47:17PM -0700, Grant Likely wrote:
> On Fri, Feb 3, 2012 at 3:35 PM, Rob Herring <robherring2@xxxxxxxxx> wrote:
...
> > +static struct irq_domain_ops irq_gc_irq_domain_ops = {
> > +       .map = irq_gc_irq_domain_map,
> > +       .xlate = irq_domain_xlate_onetwocell,
>
> Can we hard-enforce _xlate_twocell here? Are there any users using
> just one cell? Alternately, can we make the caller specify if one or
> two cells are expected?
>
I did not notice this comment until I tried Rob's v5 branch. The imx5
TZIC uses just one cell.

--
Regards,
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/