Re: [PATCH RESEND] ceph: avoid panic with mismatched symlink sizesin fill_inode()

[Alex Elder]

On Fri, 2012-02-03 at 09:55 -0500, Xi Wang wrote:
> Return -EINVAL rather than panic if iinfo->symlink_len and
> inode->i_size do not match.
> 
> Also use kstrndup rather than kmalloc/memcpy.
> 
> Signed-off-by: Xi Wang <xi.wang@xxxxxxxxx>

Looks good, though it might good to at least call
WARN_ON().  What do you think?

I will commit this (either with or without the
WARN_ON()).

Reviewed-by: Alex Elder <elder@xxxxxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/