Re: [PATCH 1/2 RESEND] gpio: Add missing spin_lock_init ingpio-ml-ioh driver

[Grant Likely]

On Wed, Feb 01, 2012 at 10:50:05AM +0800, Axel Lin wrote:
> This bug was introduced by commit 54be5663
> "gpio-ml-ioh: Support interrupt function" which adds a spinlock to struct
> ioh_gpio but never init the spinlock.
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

Applied both, thanks.

g.

> ---
>  drivers/gpio/gpio-ml-ioh.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
> index 461958f..271fd49 100644
> --- a/drivers/gpio/gpio-ml-ioh.c
> +++ b/drivers/gpio/gpio-ml-ioh.c
> @@ -448,6 +448,7 @@ static int __devinit ioh_gpio_probe(struct pci_dev *pdev,
>  		chip->reg = chip->base;
>  		chip->ch = i;
>  		mutex_init(&chip->lock);
> +		spin_lock_init(&chip->spinlock);
>  		ioh_gpio_setup(chip, num_ports[i]);
>  		ret = gpiochip_add(&chip->gpio);
>  		if (ret) {
> -- 
> 1.7.5.4
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/