Re: [PATCH] PM/Suspend: Avoid code duplication in suspend statisticsupdate

From: Srivatsa S. Bhat
Date: Wed Feb 01 2012 - 20:50:44 EST


On 02/02/2012 07:09 AM, Marcos Paulo de Souza wrote:

> The code
> if (error) {
> suspend_stats.fail++;
> dpm_save_failed_errno(error);
> } else
> suspend_stats.success++;
>
> Appears in the kernel/power/main.c and kernel/power/suspend.c.
>
> This patch just creates a new function to avoid duplicated code.
>
> Suggested-by: Srivatsa S. Bhat <srivatsa.bhat@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Marcos Paulo de Souza <marcos.mage@xxxxxxxxx>
> ---


Looks good to me :-)

Acked-by: Srivatsa S. Bhat <srivatsa.bhat@xxxxxxxxxxxxxxxxxx>

Regards,
Srivatsa S. Bhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/