Re: [PATCH] fix readahead pipeline break caused by block plug

[Wu Fengguang]

On Tue, Jan 31, 2012 at 06:57:16AM -0500, Christoph Hellwig wrote:
> On Tue, Jan 31, 2012 at 07:42:56PM +0800, Wu Fengguang wrote:
> > > So what?  Better do a bit more work now and keep the damn thing
> > > maintainable.
> > 
> > What if we add a wrapper function for doing
> > 
> >         blk_start_plug(&plug);
> >         ->direct_IO()
> >         blk_finish_plug(&plug);
> 
> No.  Just put it into __blockdev_direct_IO - a quick 2 minute audit of
> the kernel source shows that is in fact the only ->direct_IO instance
> which ever submits block I/O anyway.

Right, so nice point!

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/