Re: [PATCH v2 4/8] staging: tidspbridge: silence the compiler

From: Dan Carpenter
Date: Tue Jan 31 2012 - 03:04:38 EST


On Tue, Jan 31, 2012 at 12:12:20AM +0100, Víctor Manuel Jáquez Leal wrote:
> Silence the warning when compiling drv_interface.c
>
> Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@xxxxxxxxxx>

What does the compiler warn about here? Normally you would cut and
paste the warning into the commit message. But at least give us a
hint.

You could also reformat that printk so the message is on one line.

dev_dbg(bridge,
"%s: vm filp %p offset %x start %lx end %lx page_prot %ulx flags %lx\n",
__func__, filp, offset, vma->vm_start, vma->vm_end,
vma->vm_page_prot, vma->vm_flags);

regards,
dan carpenter


Attachment: signature.asc
Description: Digital signature