Re: [PATCH 4/4] leds-lp5521: redefinition of register bits

[Linus Walleij]

On Sat, Jan 21, 2012 at 7:09 PM, Kim, Milo <Milo.Kim@xxxxxx> wrote:

> For better readability, values of LP5521_REG_ENABLE register were redefined.
> Additional definitions: LP5521_ENABLE_DEFAULT and LP5521_ENABLE_RUN_PROGRAM.
>
> Use definition rather than hard code value.
> : 0x3F -> 'LP5521_CMD_DIRECT'
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@xxxxxx>

Looks like a good idea.

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/