Re: [PATCH v3 2/2] mmc: core: Support packed command for eMMC4.5 device

[Namjae Jeon]

2012/1/25 Namjae Jeon <linkinjeon@xxxxxxxxx>:
>>> >> +
>>> >> +static int mmc_blk_issue_packed_rd(struct mmc_queue *mq,
>>> >> + Â Â Â Â Â Â Â struct mmc_queue_req *mq_rq)
>>> >> +{
>>> >> + Â Â Â struct mmc_blk_data *md = mq->data;
>>> >> + Â Â Â struct mmc_card *card = md->queue.card;
>>> >> + Â Â Â int status, ret = -EIO, retry = 2;
> Hi. Seungwon.
> First Thansk for your reply.
> There is one more my review comment.
> I think that EIO of ret is not needed. there is no case to be skipped
> if/ese condition in do while loop.

Hi. Seungwon.

  if ((!mmc_host_is_spi(card->host) && rq_data_dir(req) != READ) ||
+                       (mq_mrq->packed_cmd == MMC_PACKED_WR_HDR)) {

it seems more better that upper if condition is changed like the below.

if (!mmc_host_is_spi(card->host) && ((rq_data_dir(req) != READ) ||
+                       (mq_mrq->packed_cmd == MMC_PACKED_WR_HDR))) {


+++ b/drivers/mmc/core/host.c
@@ -346,6 +346,8 @@ struct mmc_host *mmc_alloc_host(int extra, struct
device *dev)
       host->max_blk_size = 512;
       host->max_blk_count = PAGE_CACHE_SIZE / 512;

+       host->packed_min = 2;
+
       return host;

if packed_min is fixed value without increasing/decreasing,  it seems
more better to use macro.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/