Re: [PATCH 2/5] Dynamic ID addition doesn't need get_driver()

From: Dominik Brodowski
Date: Wed Jan 25 2012 - 14:56:08 EST


On Tue, Jan 24, 2012 at 01:34:41PM -0500, Alan Stern wrote:
> As part of the removal of get_driver()/put_driver(), this patch
> (as1511) changes all the places that add dynamic IDs for drivers.
> Since these additions are done by writing to the drivers' sysfs
> attribute files, and the attributes are removed when the drivers are
> unregistered, there is no reason to take an extra reference to the
> drivers.
>
> The one exception is the pci-stub driver, which calls pci_add_dynid()
> as part of its registration. But again, there's no reason to take an
> extra reference here, because the driver can't be unloaded while it is
> being registered.
>
> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> CC: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> CC: Jiri Kosina <jkosina@xxxxxxx>
> CC: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> CC: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>

For the PCMCIA part: Acked-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>

Thanks,
Dominik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/