Re: [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap

From: Mark Brown
Date: Tue Jan 24 2012 - 15:22:09 EST


On Tue, Jan 24, 2012 at 06:29:13PM +0100, Julia Lawall wrote:

> if (IS_ERR(saif->clk)) {
> - ret = PTR_ERR(saif->clk);
> dev_err(&pdev->dev, "Cannot get the clock: %d\n",
> ret);
> - goto failed_clk;
> + return PTR_ERR(saif->clk);

Looks like the transformation is overly enthusiastic here - the
assignment to ret is removed but ret is used in the log message.

Attachment: signature.asc
Description: Digital signature