Re: [PATCH][Trivial] Fix up version number reference ininclude/trace/events/power.h

[Jesper Juhl]

On Sun, 15 Jan 2012, Steven Rostedt wrote:

> On Sun, 2012-01-15 at 21:48 +0100, Jesper Juhl wrote:
> > What was originally going to be 2.6.41 became 3.1 .
> > 
> > Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
> > ---
> >  include/trace/events/power.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/include/trace/events/power.h b/include/trace/events/power.h
> > index 1bcc2a8..b262699 100644
> > --- a/include/trace/events/power.h
> > +++ b/include/trace/events/power.h
> > @@ -65,7 +65,7 @@ TRACE_EVENT(machine_suspend,
> >  	TP_printk("state=%lu", (unsigned long)__entry->state)
> >  );
> >  
> > -/* This code will be removed after deprecation time exceeded (2.6.41) */
> > +/* This code will be removed after deprecation time exceeded (3.1) */
> 
> Shouldn't the real fix be to remove this code? What's the use of
> changing the version number that this code will be removed from, when
> the change won't get in until after the version that this code should
> have been removed?
> 
> This is like updating 2014 calendars to say the world will end in 2012.
> 
Heh, yeah, in a way you are right. But we have lots of code in the kernel 
that says it will be removed at <some date in the past>, so I just figured 
that if this code ends up hanging around it should at least display the 
correct version number for when it /should/ have been removed.
The actual removal I'll leave up to others.

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/