Re: [PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs_add
From: Dave Jones
Date: Sun Jan 15 2012 - 10:30:34 EST
On Sun, Jan 15, 2012 at 09:16:13AM -0600, Jason Dravet wrote:
>
> This patch makes it clear that the problem is in the BIOS of the computer and not the kernel. This patch applies to kernel 3.2.1.
>
> Reported-by: Greg White <pcguy11@xxxxxxxx>
> Signed-off-by: Jason Dravet <dravet@xxxxxxxxxxx>
> Tested-by: Greg White <pcguy11@xxxxxxxx>
>
> --- dir.orig 2012-01-14 18:58:20.026745884 -0600
> +++ dir.c 2012-01-14 19:52:33.011444581 -0600
> @@ -479,6 +479,8 @@ int sysfs_add_one(struct sysfs_addrm_cxt
> (path == NULL) ? sd->s_name :
> strcat(strcat(sysfs_pathname(acxt->parent_sd, path), "/"),
> sd->s_name));
> + WARN(1, KERN_WARNING
> + "Your BIOS is broken. Please contact your computer manufacturer.");
> kfree(path);
> }
That certainly isn't always the case. Incorrectly written drivers
have also taken this codepath before now.
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/