Re: [PATCH] gpu, drm, sis: Don't return uninitialized variable fromsis_driver_load()

From: Daniel Vetter
Date: Sat Jan 14 2012 - 19:07:45 EST


On Sat, Jan 14, 2012 at 09:20:37PM +0100, Jesper Juhl wrote:
> In sis_driver_load(), the only use of 'ret' is as the return value
> from the function, unfortunately it is never initialized, so the
> function just returns garbage when it succeeds.
> To fix that, remove the variable and just return 0 directly on success.
>
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>

Woot, not one of mine!

Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
--
Daniel Vetter
Mail: daniel@xxxxxxxx
Mobile: +41 (0)79 365 57 48
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/