Re: [PATCH] ubi: Use UBI_LAYOUT_VOLUME_{TYPE, ALIGN}

From: Artem Bityutskiy
Date: Sat Jan 14 2012 - 10:36:53 EST


On Sat, 2012-01-14 at 16:34 +0100, Richard Weinberger wrote:
> Am 14.01.2012 16:11, schrieb Artem Bityutskiy:
> > On Tue, 2012-01-10 at 17:57 +0100, Richard Weinberger wrote:
> >> UBI_LAYOUT_VOLUME_TYPE and UBI_LAYOUT_VOLUME_ALIGN are currently
> >> defined but not used.
> >> Use them at least once. 8-)
> >>
> >> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> >
> > Hi Richard,
> >
> > This will break backward compatibility - older and current kernels which
> > do not have this patch will error out when the find a volume without a
> > name. The right way to do this would be to change the UBI format
> > version, but you would need a really strong reason for this.
> >
>
> Sorry, this comment makes absolutely no sense.
>
> Did you mean my other patch?
> But still, the other patch also does *not* allow volumes without names.

Yes, sorry, ignore this one - I've pushed your patch.

(Embarrassed)

--
Best Regards,
Artem Bityutskiy

Attachment: signature.asc
Description: This is a digitally signed message part