Re: [git pull] PCI changes

From: Linus Torvalds
Date: Fri Jan 13 2012 - 18:14:42 EST


On Fri, Jan 13, 2012 at 1:24 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
>>
>> So why is acpi_pci_root_add() special? Cna you explain that part to me?
>
> pcie_no_aspm() means "Do not permit ASPM to be enabled" - it doesn't
> alter the existing state. pcie_clear_aspm() does that.

I *know*.

So look again.

Why is acpi_pci_root_add() special?

Because dammit, it does exactly that pcie_clear_aspm() for the
ACPI_FADT_NO_ASPM case.

That was my question. Why does it do that, when the commit log (and
the other users) say that ACPI_FADT_NO_ASPM means "don't touch".

It touches.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/