Re: [PATCH] net: decrement memcg jump label when limit, not usage,is changed

[David Miller]

From: Glauber Costa <glommer@xxxxxxxxxxxxx>
Date: Thu, 12 Jan 2012 16:16:06 +0400

> The logic of the current code is that whenever we destroy
> a cgroup that had its limit set (set meaning different than
> maximum), we should decrement the jump_label counter.
> Otherwise we assume it was never incremented.
> 
> But what the code actually does is test for RES_USAGE
> instead of RES_LIMIT. Usage being different than maximum
> is likely to be true most of the time.
> 
> The effect of this is that the key must become negative,
> and since the jump_label test says:
> 
>         !!atomic_read(&key->enabled);
> 
> we'll have jump_labels still on when no one else is
> using this functionality.
> 
> Signed-off-by: Glauber Costa <glommer@xxxxxxxxxxxxx>
> CC: David S. Miller <davem@xxxxxxxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/