Re: [PATCH] mm: Fix NULL ptr dereference in __count_immobile_pages

[Michal Hocko]

On Thu 12-01-12 11:17:02, KAMEZAWA Hiroyuki wrote:
> On Wed, 11 Jan 2012 09:48:02 +0100
> Michal Hocko <mhocko@xxxxxxx> wrote:
> 
> > On Tue 10-01-12 13:31:08, David Rientjes wrote:
> > > On Tue, 10 Jan 2012, Michal Hocko wrote:
> > [...]
> > > >  mm/page_alloc.c |   11 +++++++++++
> > > >  1 files changed, 11 insertions(+), 0 deletions(-)
> > > > 
> > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > > > index 2b8ba3a..485be89 100644
> > > > --- a/mm/page_alloc.c
> > > > +++ b/mm/page_alloc.c
> > > > @@ -5608,6 +5608,17 @@ __count_immobile_pages(struct zone *zone, struct page *page, int count)
> > > >  bool is_pageblock_removable_nolock(struct page *page)
> > > >  {
> > > >  	struct zone *zone = page_zone(page);
> > > > +	unsigned long pfn = page_to_pfn(page);
> > > > +
> 
> Hmm, I don't like to use page_zone() when we know the page may not be initialized.
> Shouldn't we add
> 
> 	if (!node_online(page_to_nid(page))
> 		return false;
> ?

How is this different? The node won't be initialized in page flags as
well.

> But...hmm. I think we should return 'true' here for removing a section with a hole
> finally....(Now, false will be safe.)

Those pages are reserved (for BIOS I guess) in this particular case so I
do not think it is safe to claim that the block is removable. Or am I
missing something?

[...]
> > > I think this should be handled in is_mem_section_removable() on the pfn 
> > > rather than using the struct page in is_pageblock_removable_nolock() and 
> > > converting back and forth.  We should make sure that any page passed to 
> > > is_pageblock_removable_nolock() is valid.
> > 
> > Yes, I do not like pfn->page->pfn dance as well and in fact I do not
> > have a strong opinion which one is better. I just put it at the place
> > where we care about zone to be more obvious. If others think that I
> > should move the check one level higher I'll do that. I just think this
> > is more obvious.
> > 
> Hmm, mem_section and pageblock is a different chunk...
> And, IIUC, in some IBM machines, section may includes several zones.
> Please taking care of that if you move this to is_mem_section_removable()...

Thanks for pointing this out. 

> 
> Thanks,
> -Kame

Thanks for comments.
-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/